![]() Want to tidy up your commit history after the review (e.g.It has EXTREMELY POOR support for history rewrite.If several people are reviewing the changes in a pull request, how do you know that all parts of the pull request have been reviewed, and no part was left unreviewed because everyone thought that “surely the other reviewer(s) will look at this”? You can’t.Want to make sure that your build system changes are reviewed by someone who knows it well? Well, you can sort of tell a person (if you know her/his name) in a comment to “Please look at the build system changes.” – but how do you know for sure that all the relevant changes were reviewed? You can’t.It has EXTREMELY POOR support for assigning different parts of the review to different people.a line comment on a commit has a very different UI compared a line comment on the squashed history. Different comments behave in different ways.They just appear in a long, flat, chronological list, making it very hard to see any relations between comments. Want to comment on a specific issue? Sometimes you can.Want to mark a specific issue as fixed? You can’t.Want to raise an issue that must to be addressed before the review can be accepted? You can’t.Want to mark the entire pull request as reviewed? You can’t.Want to mark a file as reviewed? You can’t.Want to mark a commit as reviewed? You can’t.It has NO support for recording review progress.Here are a few of the top things that bother me (I would like to be wrong, so please correct me if I am): #SUBSHIFTER OVER A MINUTE OFF CODE#The GitHub pull request functionality is more of a chat board than a review tool, and lacks many of the features of a useful code review tool. Run server side builds and tests in the same way as you do with other builds from the repository (no special review tool integration required for your build bot, for instance).Easily pull the review branch to your local computer and try it out (build it, run tests, etc).Push changes to the code review as regular commits, using any Git client (no special review tool plugin required for your Git client, for instance).Since pull requests are based on Git branches you can do things like: The one thing that GitHub gets right is the tight integration with your Git work flow. In summary: It was not all pleasant, and by the way I apologize for this rather harsh rant. This article tries to summarize some of the problems that I have come across when trying to use GitHub pull requests for doing code reviews. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |